Sfoglia il codice sorgente

Don't concat strings and vars using double quotes

Markus Hennecke 7 anni fa
parent
commit
bb770d7359
1 ha cambiato i file con 4 aggiunte e 4 eliminazioni
  1. 4 4
      autoupdate.pl

+ 4 - 4
autoupdate.pl

@@ -689,7 +689,7 @@ sub create_dependencies_list {
 	}
 	close($in);
 	if ($? != 0) {
-		die "Unable to gather information for " . $port;
+		die "Unable to gather information for $port";
 	}
 
 	# Add the port itself to the list
@@ -824,8 +824,8 @@ open($pipe, "| tsort -r >$file") or die "ERROR: Unable to spawn tsort\n";
 foreach my $dep_entry (@dep_list) {
 	# Zap the flavors and the subpackages for our dep list
 	$dep_entry =~ s/$regex_subpkg$regex_flavor//g;
-	print $dep_entry . "\n" unless ($verbose < 5);
-	print $pipe $dep_entry . "\n";
+	print "$dep_entry\n" unless ($verbose < 5);
+	print $pipe "$dep_entry\n";
 }
 close $pipe;
 die "ERROR: Internal error" if ($? != 0);
@@ -880,7 +880,7 @@ foreach my $pkg_name (@pkg_list)  {
 	while (($jobs >= $num_jobs || can_pkg_be_build($info)) && !$abort) {
 		if ($wait_for_dep_notice == 0 && !can_pkg_be_build($info)) {
 			print STDOUT "Waiting for dependant package to finish "
-			    . "building (" . $pkg_name . ")\n"
+			    . "building ($pkg_name)\n"
 				unless ($verbose < 2);
 			$wait_for_dep_notice++;
 		}